feat(datagen): add name pools and UserIdentity generation#148
Open
Conversation
This was referenced Apr 27, 2026
Contributor
Author
This was referenced Apr 27, 2026
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
c9aa453 to
32a0573
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_name_pools_and_useridentity_generation
branch
from
e955ee9 to
6c1cf6d
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
32a0573 to
e0447ff
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_name_pools_and_useridentity_generation
branch
from
6c1cf6d to
9a3b684
Compare
eKuG
reviewed
May 8, 2026
| } | ||
|
|
||
| // GenerateUsers produces a deterministic set of users from a seed. | ||
| func GenerateUsers(seed int64, count int, domain *DomainIdentity) []*UserIdentity { |
There was a problem hiding this comment.
When GenerateUsers detects a duplicate username, it only mutates u.Username. It does not update UPN, Email, or DN, so the returned UserIdentity becomes internally inconsistent
Contributor
Author
There was a problem hiding this comment.
disambiguateUser now propagates the suffix through every identifier-bearing field. Username gets N appended, UPN/Email get the digit injected before @, DisplayName gets (N) appended, and the CN component of DN is rebuilt from the new DisplayName. New test exercises this with 200 users from a small name pool (forcing collisions) and asserts internal consistency plus uniqueness across Username, UPN, Email, and DN.
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
e0447ff to
e233d6f
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_name_pools_and_useridentity_generation
branch
from
9a3b684 to
411dc81
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
e233d6f to
61eae75
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_name_pools_and_useridentity_generation
branch
from
411dc81 to
c2d0a07
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
61eae75 to
e16eaac
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_name_pools_and_useridentity_generation
branch
from
c2d0a07 to
d4d1bd6
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
e16eaac to
cb53fb5
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_name_pools_and_useridentity_generation
branch
from
d4d1bd6 to
e969cc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Adds person-name pools and
UserIdentitygeneration built on top of them.Part of PIPE-927 common data generation package stack. Foundation for PIPE-785, PIPE-928, PIPE-943, and the rest of the simulator stack.
Checklist